Skip to content
This repository was archived by the owner on Jun 13, 2024. It is now read-only.

PSModule: Clean up code #424

Merged
merged 3 commits into from
Feb 18, 2019
Merged

Conversation

johlju
Copy link
Contributor

@johlju johlju commented Feb 15, 2019

  • Made the list entries in the CHANGELOG.md to use dash - throughout to
    be consequent (before there was a mix of dashes and asterisk).
  • Changes to PowerShellGet.ResourceHelper.
    • Cleaned up the code against the DscResources style guideline.
    • Renamed helper functions in the PowerShellGet.ResourceHelper module
      to use Verb-Noun.
    • Refactored the error handling logic to use the localization helper
      functions, and also so that the error handling could be tested.
  • Changes to PSModule.
    • Rephrased some of the localization strings.
    • Cleaned up the code against the DscResources style guideline.
      Suppressed some of the Script Analyzer rules that are not complaint
      with the the Visual Studio Code workspace settings in this repository.
    • Refactored the error handling logic to use the localization helper
      functions, and also so that the error handling could be tested.
    • Refactored the Get-TargetResource to return the correct hash table
      when the current state is absent.
    • Added new examples.
  • Added the .MetaTestOptIn.json file to opt-in for a lot of common test
    in the DscResource.Tests test framework that tests the DSC resources.
  • The examples under the folder DSC/Examples will be published to PowerShell Gallery
    so that they show up in the gallery part of Azure State Configuration.
    The examples are published under the account 'dscresourcekit' which is
    owned by the PowerShell DSC Team (DSC Resource Kit).
    • In the folder DSC/Examples a .gitattributes was added to make sure
      the examples is always checkout out using CRLF. There is an issue
      using Test-ScriptFileInfo when files is checkout out using only LF
      which is the default in AppVeyor.
    • In the file appveyor.yml the PowerShell Gallery API key was added
      for the account 'dscresourcekit', which can only be decrypted using
      the PowerShell AppVeyor account.

Fixes #418
Closes #423


This change is Reviewable

@johlju
Copy link
Contributor Author

johlju commented Feb 17, 2019

@alerickson This is ready for review.

@alerickson alerickson merged commit c44d77d into PowerShell:development Feb 18, 2019
@alerickson
Copy link
Member

alerickson commented Feb 18, 2019

Thanks again @johlju!

alerickson pushed a commit that referenced this pull request Feb 21, 2019
@johlju johlju deleted the cleanup-psmodule branch February 22, 2019 14:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants